Revert: Rich text: copy tag name on internal paste #54301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
fluiddot,
dcalhoun,
kevin940726,
Mamaduka,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: -59 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
ellatrix
added
the
[Type] Regression
t-hamano
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
LGTM !
- Pasting heading text into an empty paragraph will not convert it into a heading (which is what is expected in this PR)
- Formatting is preserved when paragraph text containing inline formatting is pasted into inline rich text.
- Formatting is preserved when pasting inline rich text containing inline formatting into an empty paragraph.
- Tested with Chrome and Firefox on Windows OS.
ellatrix
force-pushed
the
revert/e70d41914ff3c27187b3e4acfebe9db2a5843a0b
branch
from
feb6cef
to
3a9beed
Compare
ellatrix
force-pushed
the
revert/e70d41914ff3c27187b3e4acfebe9db2a5843a0b
branch
from
3a9beed
to
3e404cd
Compare
ellatrix
deleted the
revert/e70d41914ff3c27187b3e4acfebe9db2a5843a0b
branch
mikachan
added
the
[Feature] Rich Text
youknowriad
reviewed
Jan 1, 2024
| addActiveFormats( pastedValue, value.activeFormats ); | ||
| onChange( insert( value, pastedValue ) ); | ||
| return; | ||
| } |
There was a problem hiding this comment.
This change here introduced a regression. Basically if you have a plain link in your paragraph for instance, and you cut the link and paste it over some text to create a real link, the link won't be created.
There was a problem hiding this comment.
This is just reverting https://github.com/WordPress/gutenberg/pull/48254/files#diff-11720f5193f80b98003f574708df7d6107ff4f286b6a5c31f66dce1ef73b5123L154, but rebased with the multi line stuff removed 🤔
There was a problem hiding this comment.
I think the regression is caused by the change in order here #55195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This reverts #48254.
Fixes #53422
See #53453 (comment)
Sorry for the problems this introduced. And sorry to remove the new behaviour, I'll try to find a different way to do it at some point.
Why?
#48254 introduced new copying behaviour, copying the rich text wrapper tag for context when pasting. For example it allow us to retain the heading tag when pasting into an empty paragraph. But a fundamental problem is that the rich text tags could really be anything: e.g. quote has a cite rich text area, so copying the cite wrapper doesn't make sense.
Also think about instances where the structure matters: details block with rich text summary, you can't just copy the wrapper tag (summary) on its own.
It seems like we need to somehow check wether the rich text element is a full block or not. Only then it makes sense because the HTML can always be parsed as a block. Let's try that in a follow up.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast