Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automated Testing]: Fix wrong button fixture #48305

Merged
merged 1 commit into from
Feb 22, 2023
Merged

[Automated Testing]: Fix wrong button fixture #48305

merged 1 commit into from
Feb 22, 2023

Conversation

ntsekouras
Copy link
Contributor

In a different PR I noticed the extra div in this fixture and this PR just fixes that.

Testing instructions

CI is green

@ntsekouras ntsekouras added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Feb 22, 2023
@ntsekouras ntsekouras self-assigned this Feb 22, 2023
@github-actions
Copy link

github-actions bot commented Feb 22, 2023 •
edited
Loading

Flaky tests detected in f8de804.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4241324963
📝 Reported issues:

Mamaduka
Mamaduka approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@ntsekouras ntsekouras merged commit 55880c1 into trunk Feb 22, 2023
@ntsekouras ntsekouras deleted the fix/button-fixture-extra-div branch February 22, 2023 10:57
@github-actions github-actions bot added this to the Gutenberg 15.3 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

Assignees

@ntsekouras ntsekouras

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 15.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ntsekouras @Mamaduka