Site Editor: polish add template modal style #48445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
General Interface
|
Size Change: -13 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
jameskoster
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 28, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 4b38293 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48414
What?
This PR removes the unexpected space above content in modal content for adding custom templates.
Why?
This is because the WP-Admin style is applied to the
pelement.How?
I used the
Textcomponent to reset the paragraph margin. Additionally, since the bottom margin is also reset, I used theVStackcomponent to provide the space. This approach is also used in theConfirmDialogcomponent.Screenshots or screencast
The scrollbar seen in the screenshot is probably a Windows-specific problem. This issue will be fixed by #48442.
Add page template
Add page template with search control
There must be at least 10 pages in order to show the search control.
Add page template with search control (no results)
The border around the "No pages found." text seems unnatural, but if anyone agrees, I would like to add this PR to address it.
Add author template