Build: Assign edit-post global as wp.editPost
#4966
Conversation
aduth
added
Framework
| * | ||
| * @param {Object} compiler Webpack compiler | ||
| * | ||
| * @return {void} |
There was a problem hiding this comment.
Do we really need to explicitly document that function doesn't return anything? Wouldn't it enough to assume that a function by default doesn't return value?
There was a problem hiding this comment.
Do we really need to explicitly document that function doesn't return anything? Wouldn't it enough to assume that a function by default doesn't return value?
There's some precedent of this in existing core documentation. In general I'd be inclined to agree with you that it could be omitted for undefined return, but I could also see an argument for consistency / explicitness. Maybe worth bringing up in tomorrow's JS meeting? 😉
webpack.config.js
Outdated
| memo[ entryPointName ] = `./${ entryPointName }/index.js`; | ||
| entryPointNames.reduce( ( memo, entryPoint ) => { | ||
| entryPoint = castArray( entryPoint ); | ||
| const [ name, path = name ] = entryPoint; |
There was a problem hiding this comment.
Just wanted to double check if I understand how destructuring works here:
- if there is a
nameandpathprovided they are set - if the
pathis not set, we set its value asname
There was a problem hiding this comment.
Just wanted to double check if I understand how destructuring works here:
This is correct. I've added a clarifying inline comment in d3a43bf.
There was a problem hiding this comment.
Thanks, you don't always see defaults set here, using another param. Quite nice that is is possible 👍
| * | ||
| * @see webpack.TemplatedPathPlugin | ||
| */ | ||
| class CustomTemplatedPathPlugin { |
There was a problem hiding this comment.
Do we plan to extract it and move to WordPress/packages at some point? It might be useful for other repositories.
There was a problem hiding this comment.
Do we plan to extract it and move to
WordPress/packagesat some point? It might be useful for other repositories.
Yeah, seems like a generally useful plugin.
I see an error not related to this PR. Will check |
directory of resolved request is not sufficient because the resolved file of WordPress dependencies is within the `build-module` directory and would output as such. Instead format in such a way that we can call basename on the _raw_ requested path (e.g. `./editor` -> "editor", `./node_modules/@wordpress/hooks" -> "hooks")
aduth
force-pushed
the
update/edit-post-global
branch
from
938a7c1
to
81a366c
Compare
Related: #4661
This pull request seeks to ensure module assignment into the
wpglobal is camel-cased, specifically theedit-postmodule introduced in #4661 (aswp.editPost, currentlywp[ 'edit-post' ]). As our build process is generalized, this required some customization of our Webpack build configuration, including the introduction of a custom Webpack plugin for enhancing tags to include custom keys (e.g. add[dir]in addition to[name],[id], etc). This plugin could be easily externalized to a separate module, likely under the WordPress namespace.Testing instructions:
Verify that the build outputs file as expected and that the editor loads without errors.