Duotone: Fix setup state for image block. #49949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
CC: @ajlende in case you worked on this. I wonder if there's a better way to enable duotone in the literal placeholder state 🤔 |
|
Size Change: +10 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
ajlende
approved these changes
Apr 20, 2023
|
Thank you! |
bph
added
[Block] Image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
You can apply duotone to the setup state of an image:
For decorative blocks like this and others (featured image, cover, media & text) this is a useful way to build wireframe patterns that communicate: "a duotone filtered image will go here". While it's not yet applied to all those blocks yet, it works for the image block.
But not the selected state:
Why?
This regressed in how filters were applied, presumably, but is easily fixed by increasing the specificity here.
Testing Instructions
Insert an image block. Apply duotone. Select the block. Duotone should not affect the buttons and text of the selected setup state.