Add missing tooltip to Site Editor navigation Back icon button #50104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
May 3, 2023
|
Thanks. I guess we can split the following question to a separate issue, if need be:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fxies #48211
What?
FIxes the remaining part of #48211 by adding the missing tooltip of the Bacl icon button.
Why?
Ideally, tor accessibility, text buttons are always preferable. When, for very good reasons, icon buttons are used then the button accessible name must be visually exposed in some way. Tooltips are a way to do that and are required for all icon buttons. Worth reminding that's already a compromise for accessibility as not all users may be able to access the tooltip in an easy way. At least, it's better than nothing.
To discuss:
When navigating into the sub-levels of the 'drill down' menu, focus is programmatically set on the Back button. That makes the tooltip appear each time when entering a navigation sub-level. To me, that's fine. However, if that's not desirable, we should make a decision about an alternative spot where focus should land. Keeping in mind that:
I think the focus management should be double checked a bit anyways. Seems to me the last fallback isn't entirely correct.as th efallback element is not a focusable element.
How?
Changing the
aria-labelprop tolabeldoes the magic.Testing Instructions
Testing Instructions for Keyboard
See above.
Screenshots or screencast