Try reusable block as a wrapper for patterns #50309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Block] Block
talldan
requested review from
spacedmonkey,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: +704 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is an alternative to #50272.
It's possibly one way to approach #48458, rather than embracing the wp:pattern block, we instead use the wp:block (reusable block) and leverage variations to keep a consistent experience.
At the moment all patterns in templates are now wrapped in this block type (they're converted when first rendered in the editor), and given a
contentOnlylock.Why?
The idea is that this may make the potential unification of reusable blocks and patterns easier in the future.
How?
This was put together very quickly in a hack session, so I expect there may be bugs and implementation issues. I borrowed a lot from #50272.
At the moment this PR takes quite a basic approach of adding a new
typeattribute that represents the underlying resource ('reusable' for a wp_block, or 'pattern' for patterns) with a default value of reusable.Block variations are also added for these types.
In the block edit.js, save.js and index.php files, I've used simple if statements to either render a reusable block interface or a pattern interface. I expect it will be possible for a lot of the code to converge in the future, and this provides quite a good basis to refactor from.
Testing Instructions
<!-- wp:pattern {"slug":"twentytwentythree/cta"} -->block via the code editor.contentOnlymode enabled.Screenshots or screencast