Update runtime test field in WebPack config to support Windows
#50727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
the
[Feature] Interactivity API
gziolo
added
[Type] Build Tooling
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
gziolo
approved these changes
May 18, 2023
|
Thanks for the review, Greg! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the
testfield in the WebPack config that is building the runtime file for the Interactivity API to support Windows.Why?
As explained in this warning in WebPack docs: "When files paths are processed by webpack, they always contain / on Unix systems and \ on Windows. That's why using [\/] in {cacheGroup}.test fields is necessary to represent a path separator. / or \ in {cacheGroup}.test will cause issues when used cross-platform."
How?
Using
[\\/]for all the separators seems to fix the problem for Windows and it still works in other OS.Testing Instructions
Before this change
In a Windows machine, run
npm run buildcommand and check that insidebuild/block-library/interactivitytheruntime.jsfile (and minified ones) ARE NOT there.After this change
In a Windows machine, run
npm run buildcommand and check that insidebuild/block-library/interactivitytheruntime.jsfile (and minified ones) ARE there.We can also check that in other OS it keeps working as expected.