Fluid typography: extract logic to derive fluid typography settings #51188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Code Quality
|
Size Change: -43 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
This is testing nicely for me @ramonjd, thanks for following up!
Just left a couple of non-blocking nits, but this LGTM 🙂
packages/block-editor/src/components/global-styles/typography-utils.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/global-styles/typography-utils.js
Outdated
Show resolved
Hide resolved
noisysocks
reviewed
Jun 6, 2023
packages/block-editor/src/components/global-styles/typography-utils.js
Outdated
Show resolved
Hide resolved
…y settings. Why is this required? Because there's a little tap dance that's needed to check whether fluid typography is enabled via boolean or object, and also whether a maximum viewport size value can be extracted from layout settings. Adds tests as well.
…t we're supposed to pass it the return value from getFluidTypographyOptionsFromSettings - use TypographySettings as object return type - test for null values in isFluidTypographyEnabled check
ramonjd
force-pushed
the
update/fluid-typography-settings-logic
branch
from
66044e5
to
33be494
Compare
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…ordPress#51188) * This commit updates the utilities to house logic to get the typography settings. Why is this required? Because there's a little tap dance that's needed to check whether fluid typography is enabled via boolean or object, and also whether a maximum viewport size value can be extracted from layout settings. Adds tests as well. * - rename typographySettings here to typographyOptions to indicate that we're supposed to pass it the return value from getFluidTypographyOptionsFromSettings - use TypographySettings as object return type - test for null values in isFluidTypographyEnabled check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue:
What?
This commit updates the utilities to house logic to get the typography settings. See context: #51146 (comment)
Adds tests as well.
Why?
Because there's a little tap dance that's needed to check whether fluid typography is enabled via boolean or object props, and also whether a maximum viewport size value can be extracted from layout settings (if fluid typography is enabled).
How?
A few
ifs andreturnsTesting Instructions
The new and existing tests should pass.