Navigation Sidebar: Fetch the blocks from the content when trying to load navigations #52899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +256 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
scruffian
force-pushed
the
fix/useEntityBlockEditor
branch
from
94a9265
to
be2b298
Compare
scruffian
changed the title
scruffian
changed the title
scruffian
requested review from
aaronrobertshaw,
draganescu,
youknowriad and
getdave
scruffian
added
[Type] Bug
|
Flaky tests detected in e883da0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5654048075
|
aaronrobertshaw
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Thanks for the fix @scruffian 🚀
This restores the sidebar navigation editing for customized template parts. I could only replicate the original issue when a template part containing navigation had been customized.
The key change from #52417 appears to be the removal of the call to update the edited entity record. If we do come across other regressions, addressing that might be a thread to follow.
Mamaduka
reviewed
Jul 25, 2023
...es/edit-site/src/components/sidebar-navigation-screen-pattern/use-navigation-menu-content.js
Outdated
Show resolved
Hide resolved
getdave
reviewed
Jul 25, 2023
...es/edit-site/src/components/sidebar-navigation-screen-pattern/use-navigation-menu-content.js
Outdated
Show resolved
Hide resolved
…ttern/use-navigation-menu-content.js Co-authored-by: Dave Smith <getdavemail@gmail.com>
|
Merging this even though the interactivity tests are broken as this seems to be a problem already in trunk. |
getdave
added
the
Backport to WP Beta/RC
|
Can confirm that this isn't needed for 6.3 as nav appears correctly in the sidebar. Removing backport label. |
tellthemachines
removed
the
Backport to WP Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the way we load navigations from the entity, so that we create blocks which can be used to display the navigation in the sidebar.
Why?
This worked, but was broken by #52417. The problem seems to be that we were relying on the blocks property, which isn't always present.
How?
Instead of relying on
block, we can just generate them from content, usingparse.Testing Instructions
Screenshots or screencast