Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button Block styles: remove !important #5290

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Button Block styles: remove !important #5290

merged 1 commit into from
Mar 6, 2018

Conversation

Soean
Copy link
Member

@Soean Soean commented Feb 27, 2018

Description

This pull request removes !important in box-shadow and text-decoration from the button style.scss (added in #1999). We now have a wp-block-button__link class, so we don't need the !important anymore.

Fixes #5277

aduth
aduth approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowriad youknowriad merged commit b8c91ae into master Mar 6, 2018
@youknowriad youknowriad deleted the update/button-style-remove-important branch March 6, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Soean @aduth @youknowriad