-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support of sticky position in non-iframed post editor #53540
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,9 @@ | |
position: relative; | ||
display: flex; | ||
flex-flow: column; | ||
overflow: hidden; | ||
&.is-isolated { | ||
overflow: hidden; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does it hurt to always apply this rule? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, unfortunately There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oops, sorry, I meant to never apply this rule. There's no comment about why it's needed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've added a comment with explanation for both cases. I also inverted the application of the class. It seems a hair neater that way as a class isn't added for what is the expected case. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Ah, gotcha. And thanks for adding the explanatory comment @stokesman! @ellatrix there's a screengrab on the earlier PR that added |
||
} | ||
|
||
// Gray preview overlay (desktop/tablet/mobile) is intentionally not set on an element with scrolling content like | ||
// interface-interface-skeleton__content. This causes graphical glitches (flashes of the background color) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a comment prior to this rule explaining why
overflow: hidden
is only applied when.is-isolated
is applied? It's a tricky edge case this one, so could be good to make sure we don't accidentally reintroduce the problem further down the track.