Try: get_style_nodes: only return those that will be used
#53575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WordPress core uses that filter to remove the block nodes. A more performant implementation is simply return the top-level style nodes. This needs removing the filter wp_theme_json_get_style_nodes in core as well.
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/class-wp-theme-json-gutenberg.php ❔ lib/script-loader.php |
oandregal
changed the title
get_style_nodes: only return those that will be used
|
In block themes that enqueue the assets of the blocks in use, this change provides a small improvement (-2ms), it could be a little nice win. I'm confused as to why TTFB is worse for classic themes with this change (-4ms). Needs more investigation. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #45171
Extracted from #53351
What?
Do not compute block nodes in
get_style_nodesas they will be discarded.Why?
The block nodes are discarded and are calculated via a different mechanism. By not doing unnecessary work, the code is faster.
How to test
TBD.