ESLint Plugin: Bring JSDoc plugin to the latest version #53629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] ESLint plugin
This was referenced Aug 14, 2023
|
Size Change: 0 B Total Size: 1.5 MB ℹ️ View Unchanged
|
gziolo
requested review from
ajitbohra,
ntwb,
nerrad,
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel,
kevin940726 and
ellatrix
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replaces and closes: #50590. Kudos to @sharma20 for most of the work on this PR.
Fixes #50001.
Fixes #50452.
Fixes #53213.
Fixes #53553.
Why?
@wordpress/scriptsthrough@wordpress/eslint-pluginhas deprecated NPM modules and unsupported node v20. It's caused by dependencies fromeslint-plugin-jsdoc.In addition to that, the
jsdoc/newline-after-descriptionwas removed by jsdoc but is used here producing an error:See https://github.com/gajus/eslint-plugin-jsdoc/releases/tag/v42.0.0
How?
eslint-plugin-jsdocgets updated to the latest version that doesn't list Node 20 as not supported.There is a new default in
jsdoc/tag-lineswhich does the same thing, which means removing this rule should be sufficient.Testing Instructions
Run
npm run lint:js. Everything should work as before and there should be no errors or warnings from the JSDoc plugin.