Command Palette: Fix crash on block-related commands #53923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +13 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Aug 25, 2023
youknowriad
approved these changes
Aug 25, 2023
|
Thank you @t-hamano 🙇🏻 |
draganescu
added
Backport to WP Minor Release
|
Flaky tests detected in fd3ba51. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5966508312
|
|
@youknowriad @draganescu Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53863
Related to #52509
What?
This PR fixes a problem in the command palette where the editor crashes due to block-related commands.
Why?
This problem occurs when building a Gutenberg project, as mentioned in this comment. Also, when built, the callback function name is also compressed, so the replace method does not produce the intended string. There is also a problem in terms of localization
How?
I changed the command item to an object and specified the label, icon, callback function, etc. as individual properties.
Testing Instructions
add,move, etc. and that the commands are displayed.Note: While I was investigating this issue, I discovered several problems in block related actions. These are not addressed in this PR as they also occur in trunk.