Allow overriding the iOS platform destination for RN E2E testing #54079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
mokagio
commented
Aug 31, 2023
| @@ -1 +1 @@ | |||
| 2.7.5 | |||
| 2.7.4 | |||
There was a problem hiding this comment.
That is the version supported by our CI. We could of course install a new one at runtime, but that adds 4 to 5 minutes to the build.
Worth noting that version 2.7.4 and 2.7.5 both are past support. We ought to upgrade to version 3.x, but that's something we might want to do in a dedicated PR.
mokagio
commented
Aug 31, 2023
| @@ -702,7 +702,6 @@ | |||
| buildSettings = { | |||
| ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | |||
| CLANG_ENABLE_MODULES = YES; | |||
| CODE_SIGN_IDENTITY = "iPhone Developer"; | |||
There was a problem hiding this comment.
This is redundant. Removing it makes the project default to "Apple Developer" which is good enough for what we need here.
mokagio
commented
Aug 31, 2023
| else | ||
| # Run xcodebuild without piping the output | ||
| eval "$XCODEBUILD_CMD" | ||
| fi |
There was a problem hiding this comment.
I extracted the xcodebuild call for two reasons:
- Allow overriding the
-destinationparameter - Use
xcbeautifyto parse the output to make local debugging easier
mokagio
added a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
Aug 31, 2023
Base automatically changed from
mokagio/address-multiple-podfiles-warning
to
trunk
August 31, 2023 10:17
The current setup works because the resulting destination is unique in the CircleCI image. However, in the upcoming Buildkite setup the value does not work and `xcodebuild` tries to build using the VM as the destination, which fails. See https://buildkite.com/automattic/gutenberg-mobile/builds/7039#018a4555-02d8-4ce3-b463-b876b3e7a658/858-883 With an override-via-env-var in place, we'll be able to customize the destination used in CI without having to further update the code here.
Xcode sets 'Apple Developer' as the default, which is good enough for the kind of project that react-native-editor is.
Keep the logs cleaner.
mokagio
force-pushed
the
mokagio/react-native-editor-update-for-buildkite
branch
from
e6895f3
to
ebe7487
Compare
That is the version supported by our CI. We could of course install a new one at runtime, but that adds 4 to 5 minutes to the build. Worth noting that version 2.7.4 and 2.7.5 both are past support. We ought to upgrade to version 3.x, but that's something we might want to do in a dedicated PR.
geriux
approved these changes
Sep 5, 2023
geriux
added
the
Mobile App - i.e. Android or iOS
This was referenced Sep 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The core change in this PR is adding an environment variable that can be set to change the
xcodebuild-destinationparameter of one of the tests commands. This will unblock creating the bundle for SauceLabs on Buildkite, see wordpress-mobile/gutenberg-mobile#6134The other commits are tangential changes related to making the SauceLabs builds in CI possible or faster. Refer to the expanded commit messages for more details.
Why?
The context of these changes is that we are incrementally moving from CircleCI to Buildkite as the CI provider for
gutenberg-mobile. Unfortunately, there are some implicit dependencies on the CI provider and between that and this repository in the automation scripts, which is why these changes are necessary.How?
Moved the
test:e2e:build-app:ioscommand from a long inline string in thepackage.jsonto a dedicated script and made it check the environment forRN_EDITOR_E2E_IOS_DESTINATIONto set the-destinationparameter.Testing Instructions
See wordpress-mobile/gutenberg-mobile#6138 which runs the gutenberg-mobile CI against this PR.
Testing Instructions for Keyboard
N.A.
Screenshots or screencast
N.A.