SearchControl: allow for 32px compact size, introduce option to change default size to 40px
#54548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
|
@jameskoster added some testing instructions too. Let me know how this looks like (it may need some refinements around icon / button sizing) |
|
Size Change: +79 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f0b1901. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6221574205
|
|
Thanks so much :)
Is this for backwards compatibility? I'm wondering if it's necessary. Of course if there's a technical reason to keep the old sizing then that's fine, but I don't think it would be a problem to deprecate that size entirely. |
It's mostly following the approach highlighted by Lena in #46741 (she mostly took care of components sizing works but she's now AFK) |
|
Okay. I suppose we can follow-up to make current instances of SearchControl use __next40pxDefaultSize. |
jameskoster
approved these changes
Sep 19, 2023
|
Thank you for the review! Happy to tweak further if needed, as we start setting the |
ciampo
added
the
has dev note
|
Dev note added to #46741 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #54501
Part of #46741
This PR reworks the size (height) of the
SearchControlinput, updating it as per the specsWhy?
Following the latest design specs
How?
sizeprop is introduced. The prop accepts the'default'and'compact'values:'default'value will keep the component looking as-is (48pxheight)'compact'value will change the component's height to be32px(in line with theButtoncomponent whensize="compact")__next40pxDefaultSizeprop. When the prop is set totrue, thesize="default"will render the component with a height of40pxinstead of48pxTesting Instructions
__next40pxDefaultSizeprop totrue. The component should render with a 40px heightsizeprop to'compact'. The component should render with a 32px heightSmoke test the component in the editor — nothing should change for now.
Screenshots or screencast
searchcontrol-sizing.mp4