Update compact search control metrics #54663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +33 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Sep 20, 2023
ciampo
approved these changes
Sep 20, 2023
packages/components/CHANGELOG.md
Outdated
| @@ -18,6 +18,7 @@ | |||
| - `DuotonePicker/ColorListPicker`: Adds appropriate labels to 'Duotone Filter' color pickers ([#54468](https://github.com/WordPress/gutenberg/pull/54468)). | |||
| - `SearchControl`: support new `40px` and `32px` sizes ([#54548](https://github.com/WordPress/gutenberg/pull/54548)). | |||
| - `FormTokenField`: Add `tokenizeOnBlur` prop to add any incompleteTokenValue as a new token when field loses focus ([#54445](https://github.com/WordPress/gutenberg/pull/54445)). | |||
| - `SearchControl`: polish metrics for `compact` size variant ([#54663](https://github.com/WordPress/gutenberg/pull/54663)). | |||
There was a problem hiding this comment.
This should be moved under the unreleased section, under a new ### Enhancements sub-section (a new version of the package was released since this PR was opened)
|
Flaky tests detected in ccc62f1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6260731931
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #54548.
What?
Update
SizeControlmetrics when size iscompact.Why?
Better visual balance. The current spacing works well at 40/48px, but at the smaller 32px size it's a bit much.
Testing Instructions
npm run storybook:dev, openSearchControland set size tocompactBefore
After