Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Title: Insert initial block as provisional #5539

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 9, 2018

This pull request seeks to update the behavior of pressing enter from the title field to leverage the same insertDefaultBlock as the default block appender and betweenserter for consistency and so that it inherits the same "provisional" block behavior introduced in #5417.

Testing instructions:

  1. Create a new post
  2. Insert a title
  3. Press enter
  4. Press arrow up
  5. Note that after focus transitions into the title, the block which had been inserted after step 3 has been removed (the "Write your story" prompt returns)

@aduth aduth added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Mar 9, 2018
@aduth aduth merged commit 673f60e into master Mar 14, 2018
@aduth aduth deleted the fix/title-append-default branch March 14, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant