Fix lightbox trigger styles #55859
Merged
Fix lightbox trigger styles #55859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Bug
richtabor
requested review from
artemiomorales and
michalczaplinski
as code owners
|
Size Change: +227 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Nov 3, 2023
|
I just cherry-picked this PR to the 6.4-gb-sync-11.5 branch to get it included in the next release: 0289ca6 |
mikachan
pushed a commit
that referenced
this pull request
Nov 5, 2023
* Update icons * Update styles * Tweak offset values to 16
mikachan
removed
the
Backport to WP Beta/RC
mikachan
pushed a commit
that referenced
this pull request
Nov 5, 2023
* Update icons * Update styles * Tweak offset values to 16
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Nov 5, 2023
This update includes the following fixes reported after RC3: * Regression: [WordPress/gutenberg#55858 Fixes patterns not working anymore as a post template for custom post types]. Scenario: When creating a new post for any custom post type registered with its "template" argument set to a pattern. For this scenario, the pattern template no longer renders in the post editor or the frontend with 6.4, whereas it did render properly in 6.3.2. This package update resolves the console error raised: {{{ Uncaught TypeError: select(...).getCurrentTheme() is undefined }}} which restores the rendering of the pattern template. * Regression: [WordPress/gutenberg#55859 Fixes positioning and styles for the new lightbox's trigger] introduced in 6.4. Follow up to [57048], [57034], [56987], [56961], [56849], [56818], [56816]. Props renathoc, rajinsharwar, richtabor, joen, mikachan, hellofromTonya. Fixes #59411. Built from https://develop.svn.wordpress.org/trunk@57063 git-svn-id: https://core.svn.wordpress.org/trunk@56574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Nov 5, 2023
This update includes the following fixes reported after RC3: * Regression: [WordPress/gutenberg#55858 Fixes patterns not working anymore as a post template for custom post types]. Scenario: When creating a new post for any custom post type registered with its "template" argument set to a pattern. For this scenario, the pattern template no longer renders in the post editor or the frontend with 6.4, whereas it did render properly in 6.3.2. This package update resolves the console error raised: {{{ Uncaught TypeError: select(...).getCurrentTheme() is undefined }}} which restores the rendering of the pattern template. * Regression: [WordPress/gutenberg#55859 Fixes positioning and styles for the new lightbox's trigger] introduced in 6.4. Follow up to [57048], [57034], [56987], [56961], [56849], [56818], [56816]. Props renathoc, rajinsharwar, richtabor, joen, mikachan, hellofromTonya. Fixes #59411. Built from https://develop.svn.wordpress.org/trunk@57063 git-svn-id: http://core.svn.wordpress.org/trunk@56574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Nov 5, 2023
This update includes the following fixes reported after RC3: * Regression: [WordPress/gutenberg#55858 Fixes patterns not working anymore as a post template for custom post types]. Scenario: When creating a new post for any custom post type registered with its "template" argument set to a pattern. For this scenario, the pattern template no longer renders in the post editor or the frontend with 6.4, whereas it did render properly in 6.3.2. This package update resolves the console error raised: {{{ Uncaught TypeError: select(...).getCurrentTheme() is undefined }}} which restores the rendering of the pattern template. * Regression: [WordPress/gutenberg#55859 Fixes positioning and styles for the new lightbox's trigger] introduced in 6.4. Follow up to [57048], [57034], [56987], [56961], [56849], [56818], [56816]. Reviewed by jorbin. Merges [57063] to the 6.4 branch. Props renathoc, rajinsharwar, richtabor, joen, mikachan, hellofromTonya. Fixes #59411. git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57064 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Nov 5, 2023
This update includes the following fixes reported after RC3: * Regression: [WordPress/gutenberg#55858 Fixes patterns not working anymore as a post template for custom post types]. Scenario: When creating a new post for any custom post type registered with its "template" argument set to a pattern. For this scenario, the pattern template no longer renders in the post editor or the frontend with 6.4, whereas it did render properly in 6.3.2. This package update resolves the console error raised: {{{ Uncaught TypeError: select(...).getCurrentTheme() is undefined }}} which restores the rendering of the pattern template. * Regression: [WordPress/gutenberg#55859 Fixes positioning and styles for the new lightbox's trigger] introduced in 6.4. Follow up to [57048], [57034], [56987], [56961], [56849], [56818], [56816]. Reviewed by jorbin. Merges [57063] to the 6.4 branch. Props renathoc, rajinsharwar, richtabor, joen, mikachan, hellofromTonya. Fixes #59411. Built from https://develop.svn.wordpress.org/branches/6.4@57064 git-svn-id: http://core.svn.wordpress.org/branches/6.4@56575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
Nice update 👍 |
|
It looks nice. Backend.
I am wondering if the full size icon should remain focused/selected as long as nothing else is clicked? |
|
I just noticed this PR introduced a couple accessibility issues that unfortunately have been released in WordPress 6.4. I see this PR isn't associated with a related issue to allow for broader discussion. I would like to kindly remind that, as established in the contributing guidelines of this project, non-trivial pull requests should be accompanied by a related issue:
Also, a proper label I will add these points to #55513. 1 2 This is barely visible:
As opposed to the previous implementation that was way more visible:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the lightbox trigger style and position, so that they look nice regardless of the image behind.
Testing Instructions
Screenshots or screencast