Use tooltip for the Timezone only when necessary.

[afercia]

Fixes #56211

What?

The Timezone indication may render an unnecessary tooltip when the visible text and the tooltip text are the same.

Why?

There is no need to repeat in the tooltip the same information that is already in the visible text e.g. UTC+3 and again UTC+3.

How?

Checks whether the abbreviation and the detailed values contain the same information and add the tooltip conditionally.

Testing Instructions

• Repeat the steps described in the issue TimeZone: Do not show a tooltip that just repeats the visible text #56211
• Observe that the tooltip shows only when the detailed information is actually different from the visible text.

Testing Instructions for Keyboard

Screenshots or screencast

[ciampo]

Suggested change

	: `(${ zoneAbbr }) ${ prettyTimezoneString }`;
	: `(${ zoneAbbr }) ${ prettyTimezoneString }`.trim();

[ciampo]

Could we instead check for

Suggested change

	const isAbbrSameAsDetails =
	`${ zoneAbbr } ${ prettyTimezoneString }`.trim() === zoneAbbr;
	const isAbbrSameAsDetails = timezoneDetail === zoneAbbr;

?

[afercia]

It would not work because timezoneDetail may contain the parenthesis around zoneAbbr in fact the string in the ternary above contains parenthesis ( ... ) so that the comparison would happen between, for example:
(UTC+5.30) and UTC+5.30 and thus be falsy.

[afercia]

We could entirely remove the parenthesis maybe? They are only used in the Tooltip:

This is how it would look without parenthesis:

[ciampo]

New idea that doesn't involve making formatting changes: could we check instead that

Suggested change

	const isAbbrSameAsDetails =
	`${ zoneAbbr } ${ prettyTimezoneString }`.trim() === zoneAbbr;
	const isAbbrSameAsDetails = prettyTimezoneString.trim().length === 0;

[afercia]

Ok. I renamed the variable and added a comment for better clarity.

[github-actions]

Flaky tests detected in a7dd3b9.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7087119295
📝 Reported issues:

• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js

[ciampo]

🚀