Editor: Unify show icon labels preference #57480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
getdave and
aristath
and removed request for
a team
24 tasks
|
Size Change: +50 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jan 2, 2024
youknowriad
force-pushed
the
update/show-icon-labels-pref
branch
from
4995ed5
to
c5309a5
Compare
youknowriad
force-pushed
the
update/show-icon-labels-pref
branch
from
429a995
to
587c7d6
Compare
|
Rebased and added the migration here too. |
ntsekouras
approved these changes
Jan 3, 2024
| ( select ) => { | ||
| export default function PostViewLink() { | ||
| const { hasLoaded, permalink, isPublished, label, showIconLabels } = | ||
| useSelect( ( select ) => { |
There was a problem hiding this comment.
It's really interesting to see in how many components we were passing this prop down..
There was a problem hiding this comment.
yep, good cleanup
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
Similar to #57468
What?
This PR continues the work on the great unification between post and site editors. In this PR we're unifying the "Show button text labels" preference. If the user enables it in the post editor, the setting should be used in the site editor as well.
Testing instructions
Show button text labels" preference in the post editor (toggle the checkbox in the preferences -> accessibility panel)