Global Styles: Correctly decode border color values #57876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
commented
Jan 16, 2024
|
Size Change: -35 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Not sure when this bug crept in but it looks like it could have been around the time the panels were unified between the editors. Thanks for digging into it and creating the fix @t-hamano 👍
✅ Can replicate the issue on trunk
✅ Issue is resolved on this PR
✅ Works on in both editors and frontend
✅ Works for unified or split borders
LGTM 🚢
|
Thanks for the review @aaronrobertshaw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52733
What?
This PR fixes an issue where border color checkmarks are missing in the Global Styles.
87831ece04106b09c02fab99ce21b73c.mp4
Why?
With the current logic, the border color is decoded as follows:
decodeColorValue()functiondecodeColorValue()function, find the color that matches the format'var:preset|color|' + slugamong all colors.However, when the Global Style is saved after the palette is selected, the color value is converted to a format called
var(--wp--preset--color--{slug}).This format no longer matches the
'var:preset|color|' + slugformat, so the color cannot be found and converted to the actual color value. As a result, the color popover recognizes it as a custom color and does not check the original palette.How?
Instead of the
decodeColorValue()function, simply use thedecodeValue()function.My understanding is that when decoding a color, there is no need to consider whether the current color exists in color palettes. We should simply convert the color slug to the corresponding color value via
decodeValue().Testing Instructions
Screenshots or screencast
a549e25533b54973b15e1d14039dee4f.mp4