Implement Tabs in widget editor settings #57886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -463 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
chad1008
added
[Type] Enhancement
chad1008
requested review from
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel and
kevin940726
as code owners
ciampo
reviewed
Jan 18, 2024
chad1008
force-pushed
the
tabs-widget-settings
branch
from
34cf770
to
db90c78
Compare
|
After some testing and looking more closely at the logic controlling which tab panel is displayed, I don't think this sidebar is going to subject to the race condition we saw in the editor. I've added code comment mentioned in the last round of feedback, and once CI passes I think this one should be good to go. |
ciampo
reviewed
Feb 1, 2024
| </Button> | ||
| <Tabs.Context.Provider value={ tabsContextValue }> | ||
| <Tabs.TabPanel tabId={ WIDGET_AREAS_IDENTIFIER }> | ||
| <WidgetAreas |
There was a problem hiding this comment.
Noting that, compared to the previous code, the contents of the tab panels are now wrapped inside an additional div. At a quick glance, I didn't notice any side effects, though.
chad1008
force-pushed
the
tabs-widget-settings
branch
from
7bce5f2
to
9ac172b
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks @ciampo! Open feedback should all be addressed! |
ciampo
force-pushed
the
tabs-widget-settings
branch
from
9ac172b
to
2d375e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replace existing list-based tabs the new
Tabscomponent in the site widget settings sidebarWhy?
The current implementation was necessary because our legacy
TabPanelcomponent was not granular enough to be applied in this sidebar, due in large part to the internals of the theComplementaryAreathe sidebar uses.How?
Using the new, more granular sub-components of
Tabs, we can render the appropriate parts of the UI viaComplementaryArea'sslot/fill, and pass theTabscontext to those components as needed.This implementation is very similar to the one used previously in #55360.
Testing Instructions
Note: to test smaller/mobile viewports, make sure your viewport is at least 600px in width. Because it's technically a pinned item, this sidebar is intentionally disabled on smaller screens.
Testing Instructions for Keyboard
tablistand focuses the next element instead (the close button)