New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Block editor: avoid list re-rendering on select" #58147
Merged
ellatrix
merged 1 commit into
trunk
from
revert-57188-try/avoid-items-rerender-selection
Jan 23, 2024
Merged
Revert "Block editor: avoid list re-rendering on select" #58147
ellatrix
merged 1 commit into
trunk
from
revert-57188-try/avoid-items-rerender-selection
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Jan 23, 2024
state.blocks.order, | ||
state.selection.selectionStart.clientId, | ||
state.selection.selectionEnd.clientId, | ||
state.blockVisibility, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I guess this is creating a new array when the block visibility changes, but that still doesn't explain the typing regression
Size Change: -28 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
cbravobernal
added
[Type] Performance
Related to performance efforts
[Package] Block editor
/packages/block-editor
labels
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #57188
This introduced a typing performance regression.