Block editor: avoid list re-rendering on select #57188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +21 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Dec 20, 2023
| if ( hasSelectedBlocks && hasVisibleBlocks ) { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Could this be a private selectors, something like getSelectedBlocksAtLevel( rootClientId ) and getVisibleBlocksAtLevel( rootClientID ) or something like that?
There was a problem hiding this comment.
I was thinking about that, but it didn't feel worth it to create another selector for this, especially since it's such a weird optimisation. Also we already have access to the block order here. What do you think?
There was a problem hiding this comment.
Ideally we also prevent re-rendering the current list with the selected block, but I don't know of a way to do that without introducing another block editor store subscription per block.
There was a problem hiding this comment.
To be honest, with private APIs, I think the purpose becomes clearer with a selector that without.
There was a problem hiding this comment.
Ok, will add them as selectors then :)
youknowriad
approved these changes
Dec 20, 2023
ellatrix
force-pushed
the
try/avoid-items-rerender-selection
branch
from
03b739d
to
a7f0f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR avoids the re-rendering of
Itemsif the selection changes, but the list doesn't include the selected (or visible) block at all.Note: while we could create another
useSelectcall for each block, check if it's selected, and then turn on the AsyncProvider, there's a balance to be struck between optimising type and block select. I think typing is more important that block select, so let's avoid introducing anotheruseSelectper block.But we can avoid re-renders for other block lists. For example, in the large posts, there are many list and quote blocks.
Why?
First run: -5% (select/focus)
Second run: -4.6%
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast