-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block editor: avoid list re-rendering on select #58435
Open
ellatrix
wants to merge
2
commits into
trunk
Choose a base branch
from
try/avoid-items-rerender-selection
base: trunk
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +44 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Flaky tests detected in f912907. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7710557285
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Attempts my original implementation of #57188 again. Normally this should also improve
This PR avoids the re-rendering of
Items
if the selection changes, but the list doesn't include the selected (or visible) block at all.Note: while we could create another
useSelect
call for each block, check if it's selected, and then turn on the AsyncProvider, there's a balance to be struck between optimising type and block select. I think typing is more important that block select, so let's avoid introducing anotheruseSelect
per block.But we can avoid re-renders for other block lists. For example, in the large posts, there are many list and quote blocks.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast