Components: Allow limiting the number of maximum visible Snackbars #58559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
ajitbohra,
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel and
kevin940726
as code owners
|
Size Change: +46 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
requested review from
mirka,
jasmussen and
richtabor
and removed request for
draganescu,
adamziel,
noisysocks,
talldan,
ajitbohra,
kevin940726 and
tellthemachines
draganescu
approved these changes
Feb 1, 2024
|
I like it, but not that the 3+ snackbars show up after dismissing a more recent one. I would expect that the old snackers are actually gone when they're "gone". |
|
I checked other libraries like Sonner, and they have the same behavior. The prop controls how many Snackbars are visible simultaneously; it's not actually removing the snackbars from the store. |
|
Is there a reason the consumer can't modify the notice array themselves before it hits |
I don't have a strong opinion here, happy to move logic into consumers. I will create a follow-up tomorrow morning. |
|
Here's the follow-up. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #53201.
PR updates the
SnackbarListcomponent to allow limiting the number of maximum visible Snackbars.Why?
Reduces noise in the editors.
How?
Introduces new
maxVisibleproperty and sets it to3for post and site editors.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2024-02-01.at.17.23.30.mp4