Save entities panel: update styles #58706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
Size Change: +58 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Thank you for astoundingly fast work. Let the record show I owe you a beverage. This is clearer. A few things if possible;
A quick sketch of some options: 
In the first column, it's mainly about splitting out the diffent category of changes. Blocks on one line, elements on another, color, typography on still others. I have a feeling this might be a headache, but it would also allow us to further reduce the repeated text, i.e. "Button, Caption, Heading elements" rather than "Button element, Caption element, Heading element". In the second column, the first list item, with blocks, is taken a step further, with each block name replaced by the block icon instead. Let me know what you think! Thanks again. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
- The individual global style changes are shown below the checkbox, typography $gray-700 color and $helptext-font-size. - The individual items next to the checkbox are no longer bold, they are regular text. - The wording has been changed for pages being edited, to avoid the widow. Instead of "The following content has been modified." it's "The following has been modified.
ramonjd
force-pushed
the
update/saved-entity-styles
branch
from
ccbcc9b
to
7c8e059
Compare
|
Flaky tests detected in 7c8e059. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7807136576
|
|
Thanks again for the quick feedback!! 🍺
There was a version of this feature on the original PR: #56577 (comment) 
It involves rejigging the output of the compare function to enable grouping by blocks, settings, elements etc. The results can be still limited to I reckon this would be be better addressed in another PR as I'd need to update tests etc Happy to spin one up to try it out. I'll try with text for block names first to test my assumptions.
This PR takes care of that already, if I've not missed something 🤔 
|
|
Right, sorry for doubling back on that conversation. I still think it's worth going back to that, though I'd not do the "Blocks: " in bold, I'd just have " blocks." at the end. Speaking of, what might go in the "and 1 more change"? — if we can't tell you what it is, so you can't decide whether to save it or not, we shouldn't show it at all, IMO. Definitely okay to look at separately, and not urgent. Got the entire beta period for this, and thank you for helping. And yes indeed, this looks right, I don't know why, perhaps a vestige of my env, but previously I saw something else in my local branch:
|
jasmussen
approved these changes
Feb 7, 2024
Excellent! I'll add it to the list.
Good question. It's definitely possible to make the There could be 1 change there could be 100, so there has to be some level of truncation. At the moment, there is an order of priority, however, whereby body styles and blocks will be at the start of the list, so I suppose there'll be some "meat in the sandwich" regardless. 😄 I'll look at this when I start the list tweaking above.
Thank you too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR:
$gray-700color and$helptext-font-size."The following changes have been made to your site, templates, and content."to"There are <strong>%d site changes</strong> waiting to be saved."Why?
Design updates
See:
Testing Instructions
In the site editor, create some changes to:
Save the site and checkout the save panel.
Do the same in the post editor (minus global styles).
Thank you!
Screenshots or screencast
Before
After