Global style changes: refactor output for a more flexible UI and grouping #59055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
Size Change: +169 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cb0f9c2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7952687140
|
ramonjd
requested review from
kevin940726,
Mamaduka and
ellatrix
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Nice follow-up! The code change looks great to me (I like the array of tuples idea 👍), and it looks nice for me in the revisions panel:
The only visual thing that looked slightly off to me is the space between the Custom Styles toggle button and the list in the Save flyout. To my eyes, I'd put the list a little closer to the toggle, but I'm no designer!
It'd be good to see what @jasmussen or @jameskoster think when they get a chance to take a look, but once the designers are happy, this LGTM 👍
|
Oh, one other thing, it might be worth giving this a rebase to roll in #59101, otherwise some of the Typography panels throw an error (just in case anyone runs into it while testing). |
Good spotting, it does look a little vast. I'll update. Thanks for testing @andrewserong ! |
ramonjd
force-pushed
the
refactor/global-styles-changes-output
branch
from
343485a
to
d826735
Compare
|
Agreed with Andrew about the spacing in the save panel. Additionally the alignment of the bullets in the revisions panel is a little off. Notice how they hang further over than all the other content: 
Obviously it's separate, but I also noticed the "Apply" button is using the old 36px size. It would be good to follow up with an update to use the |
t-hamano
reviewed
Feb 16, 2024
packages/block-editor/src/components/global-styles/get-global-styles-changes.js
Outdated
Show resolved
Hide resolved
t-hamano
reviewed
Feb 16, 2024
packages/block-editor/src/components/global-styles/get-global-styles-changes.js
Show resolved
Hide resolved
t-hamano
reviewed
Feb 16, 2024
packages/block-editor/src/components/global-styles/get-global-styles-changes.js
Show resolved
Hide resolved
t-hamano
reviewed
Feb 16, 2024
packages/block-editor/src/components/global-styles/get-global-styles-changes.js
Outdated
Show resolved
Hide resolved
t-hamano
reviewed
Feb 16, 2024
packages/editor/src/components/entities-saved-states/entity-type-list.js
Outdated
Show resolved
Hide resolved
t-hamano
reviewed
Feb 16, 2024
packages/edit-site/src/components/global-styles/screen-revisions/revisions-buttons.js
Show resolved
Hide resolved
t-hamano
reviewed
Feb 16, 2024
packages/block-editor/src/components/global-styles/get-global-styles-changes.js
Show resolved
Hide resolved
Updated to compact in this PR 👍🏻 
If it looks weird I can revert in a follow up. Thank you! |
ramonjd
force-pushed
the
refactor/global-styles-changes-output
branch
from
d826735
to
5b66f47
Compare
|
Thanks, folks for testing this PR! |
remove top margin
ramonjd
force-pushed
the
refactor/global-styles-changes-output
branch
from
5b66f47
to
cb0f9c2
Compare
ramonjd
added
the
Backport to WP Beta/RC
getdave
pushed a commit
that referenced
this pull request
Feb 20, 2024
…ping (#59055) * Refactoring output for a more flexible UI and grouping * update e2e test * Update comments and tests remove top margin * Localize comma separators and period Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: 234fb7d |
getdave
removed
the
Backport to WP Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
…ping (#59055) * Refactoring output for a more flexible UI and grouping * update e2e test * Update comments and tests remove top margin * Localize comma separators and period Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR refactors the return value of
getGlobalStylesChangesto group changes into 'blocks', 'elements', 'settings', and 'styles'.Why?
Follow up to:
How?
Groups concatenated changes into 'blocks', 'elements', 'settings', and 'styles' groups, and adds the "group" name to the end of the concatenated string.
Testing Instructions
This change affects the save entities panel and the global styles revision items, both of which display global styles changes.
"Color, Typography settings."Run the tests!
npm run test:unit packages/block-editor/src/components/global-styles/test/get-global-styles-changes.jsScreenshots or screencast
Before
After