Popover: add box-sizing reset style
#58871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: -23 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewhayward
approved these changes
Feb 9, 2024
Co-authored-by: Andrew Hayward <andrew.hayward@automattic.com>
t-hamano
changed the title
box-sizing:resetbox-sizing reset style
Sorry for confusing you 😅 Is the current title appropriate? |
Thanks! Much clearer now 👍 |
|
While I like this PR, It makes me think that popover is not the only component that should have this built-in. Almost all components should have it. What if you use any component outside edit-post or edit-site... I kind of wish we can remove the "reset" from edit-post, edit-site and popovers to get some clarity on which components actually need this. |
Previous discussion of this issue here: #42415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58865
Fixes #56190
Alternative to #56325
What?
This PR applies
box-sizingreset style to thePopovercomponent itself to prevent unintended horizontal scrollbars from appearing in any context. This will prevent unintended scroll bars from appearing in the popover of the navigation block in the Site Editor.Why?
Box sizing reset style for Popover was being applied on each editor instance, not on the component itself. However, unlike the post editor, this reset was not applied in the Site Editor.
gutenberg/packages/edit-site/src/style.scss
Lines 70 to 74 in 9ca92ad
I suspect that this is the cause of this issue.
How?
Applied a box sizing reset style to the component itself and removed the reset mixin when it was no longer needed.
As a further step, we might also apply a similar approach to the
Modalcomponent.gutenberg/packages/edit-post/src/style.scss
Lines 51 to 53 in 31d5bd0
gutenberg/packages/edit-site/src/style.scss
Lines 72 to 74 in 31d5bd0
gutenberg/packages/edit-widgets/src/style.scss
Lines 21 to 22 in 31d5bd0
Testing Instructions