New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add richText identifier to blocks #59056
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thanks for the PR, @sunil25393! Could you include testing instructions in the PR description? |
@Mamaduka Updated PR description with testing instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for a thorough fix 👍
@sunil25393 Can you please rebase your fork branch onto the latest |
… sunil25393fix-issue-58996
Co-authored-by: sunil25393 <sunil25393@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
Fixed #58996
What?
Added
RichText
Identifier to some blocks.Why?
getSelectionStart()
function of block editor return number as attribute key for blocks instead of attribute name in string.How?
I have added
RichText
Identifier argument for some block'sRichText
component where this argument was missing.Testing Instructions
wp.data.select("core/block-editor").getSelectionStart()