Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add richText identifier to blocks #59056

Merged
merged 3 commits into from Mar 21, 2024

Conversation

akasunil
Copy link
Contributor

@akasunil akasunil commented Feb 15, 2024

Fixed #58996

What?

Added RichText Identifier to some blocks.

Why?

getSelectionStart() function of block editor return number as attribute key for blocks instead of attribute name in string.

How?

I have added RichText Identifier argument for some block's RichText component where this argument was missing.

Testing Instructions

  • Go to gutenberg editor
  • Focus on core/file block
  • Execute wp.data.select("core/block-editor").getSelectionStart()
  • you will receive focused attribute name as string ( either fileName or downloadButtonText, whichever you are editing) instead of number

Copy link

github-actions bot commented Feb 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sunil25393 <sunil25393@git.wordpress.org>
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks labels Feb 15, 2024
@Mamaduka
Copy link
Member

Thanks for the PR, @sunil25393! Could you include testing instructions in the PR description?

@akasunil
Copy link
Contributor Author

@Mamaduka Updated PR description with testing instructions

Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for a thorough fix 👍

@jsnajdr
Copy link
Member

jsnajdr commented Mar 21, 2024

@sunil25393 Can you please rebase your fork branch onto the latest trunk? That should hopefully fix the failing e2e tests.

@Mamaduka Mamaduka merged commit d969294 into WordPress:trunk Mar 21, 2024
55 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 21, 2024
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Package] Block library /packages/block-library and removed [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks labels Mar 21, 2024
@akasunil akasunil deleted the sunil25393fix-issue-58996 branch March 21, 2024 09:45
@bph bph changed the title Add richText Identifire to blocks Add richText identifier to blocks Mar 21, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
Co-authored-by: sunil25393 <sunil25393@git.wordpress.org>
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return AttributeKey as number
3 participants