RichText: document the identifier prop #60036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Bug
|
Size Change: +34 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 014f6eb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8359866810
|
|
It would be good to document the |
|
#59056 by @sunil25393 contains all the changes I did, except one: fixing the React Native version of the Search block. Which was adding |
jsnajdr
force-pushed
the
fix/rich-text-identifiers
branch
from
014f6eb
to
49cbb83
Compare
jsnajdr
changed the title
|
After rebase the PR is empty, @sunil25393 incorporated all the extra changes. So I'm repurposing it to document the |
Mamaduka
approved these changes
Mar 21, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RichTextcomponent, when used in a block edit function, should have anidentifierprop that's identical to the name of the block attribute that it's bound to. Theidentifieris then used as theattributeKeyvalue in selection, and is also used when splitting or merging blocks.This PRs fixes this for many core blocks.
Before this PR, you would see an auto-generated
attributeKeyon selection when editing, e.g., the Categories block:After this PR, the selection very nicely references the
prefixattribute that's being edited: