Quote block: button for cite add/remove #59073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
added
[Block] Quote
|
Size Change: -1.1 kB (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b4c8097. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7976958953
|
|
I like this, I think we can move forward. Here's a quick GIF, I'll describe it in the next paragraph:
The GIF also shows two other issues. First off, that even when moving the citation to the toolbar, there's still a layout shift happening when you select the quote block. This appears to be the appender appearing and disappearing. But this issue is not present when selecting a group block where the appender also appears, so this is a layout shift we should fix in this branch. Secondly, it shows an issue, almost certainly unrelated to this branch, where if you quickly toggle on and off in succession captions on an image, the inline toolbar appars to shift places. Not sure what that is, and separate. Another thought, let's try the verse icon for the citation button: If we can add that icon, and fix the layout shift, I'd say we can ship this. |
Not sure why this would be an issue with this branch. Probably a styling issue with the inserter on quote block which seems out of scope for this PR. I don't see the current theme I have enabled. Updating the icon now. |
ellatrix
force-pushed
the
try/quote-cite-button
branch
from
06a2f75
to
5dfe5c6
Compare
|
Icon changed. |
mtias
reviewed
Feb 20, 2024
| } | ||
| /> | ||
| ) } | ||
| <Caption |
There was a problem hiding this comment.
Should we skip doing this for the pullquote block?
mtias
approved these changes
Feb 20, 2024
Seems fine to fix separately, but the the issue is invisible in trunk, but super visible here, so if we merge this one, we will need to fix the other issue shortly after. |
|
@jasmussen What if we just remove the appender? It doesn't seem so useful in the quote block. You can press enter and use the empty inserter. |
IMO we need to track down why the quote block uses a different appender than the group block. It's outputting different CSS classes. As a container block of anything, it seems prudent to be consistent with other containers. |
ellatrix
force-pushed
the
try/quote-cite-button
branch
from
b480cdc
to
45a9eea
Compare
ellatrix
force-pushed
the
try/quote-cite-button
branch
from
45a9eea
to
d67fad9
Compare
ellatrix
force-pushed
the
try/quote-cite-button
branch
from
d67fad9
to
c11e787
Compare
|
@dcalhoun Ah, thanks! I missed that. I re-applied your change but without the pull quote changes which were reverted for the web side as well. |
* test: Define missing `logException` native module mock Prevent cryptic test failure messages originating from invoking this undefined method, which prevented the original error message from surfacing in the test failure log. * refactor: Export private API Rich Text module This export was added for interoperability with the web version modified in #58916.
This was referenced Mar 29, 2024
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: mtias <matveb@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
All blocks with caption currently have a button to add/remove the caption. But not quote, which has caption-like logic. Let's do the same for caption and reuse the existing caption util.
Not sure if this helps with #15308.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast