Quote block: remove appender #60307
Merged
Quote block: remove appender #60307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +45 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
This fixes the layout shifting issue. GIF showing clicking the quote block to show a layout shift in trunk:
After, GIF showing the same approach but without the layout shift:
I'd tend to agree that the fixed-position appender as exists in group and other containers may not be needed here, since it's a text block primarily. But it may still be worth investigating, separately, why this container block has a layout shift with the appender present, whereas the Group block does not.
|
@jasmussen Because even though the appender is position: absolute, the quote has a padding that makes the margin of the paragraph visible, I guess that happens when there's an element after the paragraph even though it positioned. 
|
|
Interesting, a paragraph inside a group is not affected by this, presumably that would be the same no? |
|
@jasmussen No, because that paragraph doesn't have any margin. The CSS from the theme is: .wp-block-quote :where(p) {
margin-block-start: 0;
margin-block-end: calc(var(--wp--preset--spacing--10) + 0.5rem);
} |
|
Hmm. Curious. In any case, happy to move forward. And the more we can do without that fixed-position appender, IMO, the better. Text-first blocks are the easiest to remove from. |
|
Yeah agreed. Again a reason to not render these appenders in the canvas. We already do that for some appenders but not all. We should refactor that. |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses #59073 (comment).
I'm not convinced we should add an appender for the quote block at all. Quote contents is usually text and easy to press Enter to add blocks, and an empty paragraph comes with an appender.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast