Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace isSmall prop with size in NavigationMenuSelector #59667

Merged

Conversation

jaclync
Copy link
Contributor

@jaclync jaclync commented Mar 7, 2024

Part of #53560

What?

Now that the isSmall prop is deprecated in Button which is used inside DropdownMenu, this PR replaces the isSmall usage in NavigationMenuSelector component in the block editor.

Why?

isSmall prop has been deprecated in Button and we should replace it with size="small" in all places in the code base.

How?

It replaces the isSmall prop only in NavigationMenuSelector in the DropdownMenu as I ran out of time to test other components.

Testing Instructions

  • Open the Gutenberg editor by creating or editing a post in wp-admin
  • Add a new block called Navigation --> ensure the vertical three-dot toolbar icon in the sidebar (Block > Menu) stays the same size

Testing Instructions for Keyboard

Screenshots or screencast

No visual changes are expected.

before after
Screenshot 2024-03-07 at 2 59 29 PM Screenshot 2024-03-07 at 2 59 38 PM

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jaclync! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@jaclync jaclync marked this pull request as ready for review March 7, 2024 07:38
@jaclync jaclync requested a review from ajitbohra as a code owner March 7, 2024 07:38
Copy link

github-actions bot commented Mar 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jaclync <jaclync@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested a review from a team March 7, 2024 07:40
@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components [Package] Block library /packages/block-library labels Mar 7, 2024
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and thank you for adding a test!

@mirka mirka enabled auto-merge (squash) March 7, 2024 07:46
@mirka mirka merged commit e286e0a into WordPress:trunk Mar 7, 2024
62 of 66 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 7, 2024
@jaclync jaclync deleted the issue/53560-replace-isSmall-with-size branch March 11, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Block library /packages/block-library [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants