Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace isSmall prop with size in NavigationMenuSelector #59667

Merged
merged 2 commits into from Mar 7, 2024
Merged

Replace isSmall prop with size in NavigationMenuSelector #59667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdddd88
Replace `isSmall` with small `size` prop in `NavigationMenuSelector`.
jaclync Mar 7, 2024
f5282fb
Add a test case to ensure `size="small"` on a `Button` sets the class…
jaclync Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-library/src/navigation/edit/navigation-menu-selector.js
View file
Open in desktop
Expand Up @@ -131,7 +131,7 @@ function NavigationMenuSelector( {
<DropdownMenu
label={ selectorLabel }
icon={ moreVertical }
toggleProps={ { isSmall: true } }
toggleProps={ { size: 'small' } }
>
{ ( { onClose } ) => (
<>
Expand Down
5 changes: 5 additions & 0 deletions packages/components/src/button/test/index.tsx
View file
Open in desktop
Expand Up @@ -593,6 +593,11 @@ describe( 'Button', () => {
expect( screen.getByRole( 'button' ) ).toHaveClass( 'is-small' );
} );

it( 'should have the is-small class when small class prop is passed', () => {
render( <Button size="small" /> );
expect( screen.getByRole( 'button' ) ).toHaveClass( 'is-small' );
} );

it( 'should prioritize the `size` prop over `isSmall`', () => {
render( <Button size="compact" isSmall /> );
expect( screen.getByRole( 'button' ) ).not.toHaveClass(
Expand Down