Interactivity: Strict type checking #59865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
[Type] Code Quality
sirreal
force-pushed
the
add/interactivity-type-checking
branch
from
b46f01a
to
393c6ba
Compare
sirreal
commented
Apr 10, 2024
packages/interactivity/tsconfig.json
Outdated
| "strictNullChecks": false, | ||
| "strictPropertyInitialization": false, | ||
|
|
||
| "noImplicitAny": false |
There was a problem hiding this comment.
We'll gradually want to remove these so all strictness is enabled.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +126 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
sirreal
force-pushed
the
add/interactivity-type-checking
branch
from
8fc589e
to
67ab2b6
Compare
sirreal
commented
Apr 10, 2024
packages/interactivity/src/vdom.ts
Outdated
Comment on lines
43
to
47
| * @param root The root element or node to start traversing on. | ||
| * @return The resulting vDOM tree. | ||
| */ | ||
| export function toVdom( root ) { | ||
| export function toVdom( root: Node ): [ string | VNode | null, Node | null ] { |
There was a problem hiding this comment.
I'm not happy with the changes here…
There was a problem hiding this comment.
toVdom is an internal function. So TS here is not critical. Don't let this block your PR 😄
sirreal
force-pushed
the
add/interactivity-type-checking
branch
from
67ab2b6
to
b681df1
Compare
sirreal
force-pushed
the
add/interactivity-type-checking
branch
from
b681df1
to
8110436
Compare
|
This needs a changelog entry. It's strict null type checked now so the generated types should be better. I think there was an issue around some possible nulls not being reflected in types (around getElement?) that should be fixed now. |
Done in 982606e |
sirreal
commented
May 15, 2024
|
This should fix the types that were a problem in #59757 |
sirreal
commented
May 15, 2024
| let ignore = false; | ||
| let island = false; | ||
|
|
||
| for ( let i = 0; i < attributes.length; i++ ) { | ||
| const n = attributes[ i ].name; | ||
| const attributeName = attributes[ i ].name; |
There was a problem hiding this comment.
🚀 Thanks for making this easier to read.
sirreal
commented
May 15, 2024
cbravobernal
approved these changes
May 15, 2024
There was a problem hiding this comment.
We need this PR (we can iterate later if needed) merged asap so it does not conflict with future developments.
Great work @sirreal
sirreal
commented
May 15, 2024
sirreal
commented
May 15, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Typecheck more of the interactivity package.
Part of #60219
Why?
The package is partially TypeScript and has relaxed strictness that reduces the quality of the produced type declarations.
Types get better!
How?
Migrate more file to TypeScript and fix type errors.
Testing Instructions
CI should be sufficient.