Site Editor: Add rename page action #60230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
aaronrobertshaw
requested review from
noisysocks,
talldan,
kevin940726 and
ntsekouras
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aaronrobertshaw
commented
Mar 27, 2024
This was referenced Mar 27, 2024
|
Size Change: +130 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Mar 27, 2024
ntsekouras
reviewed
Mar 27, 2024
ntsekouras
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Thanks so much @aaronrobertshaw! This looks good! I've left a small comment for the success message and small ones for consistency. Other than that, this will be ready to land.
|
I appreciate the speedy and insightful review @ntsekouras 🚀 I'll address the feedback when I'm back from AFK next week. |
ntsekouras
force-pushed
the
add/page-rename-action
branch
from
e9e2028
to
d7823cb
Compare
|
Thanks for the tweaks and pushing this one across the line 🙇 |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Adds rename action for the pages dataview in the site editor
Why?
If a page doesn't include a Title block there's no easy way to update the page title in the site editor.
How?
Adds a new
renamePostActionto the site editor's actions component.Note: The modal content will be refactored into a shared component in a follow-up to this PR that will add a rename page command as well.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-03-27.at.2.33.49.PM.mp4