Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise capitalisation of Navigation Menu in sidebar #60527

Conversation

xhemals
Copy link
Contributor

@xhemals xhemals commented Apr 6, 2024

What?

Standardising the capitalisation of the phrase "Navigation Menu" in the sidebar. Carrying on from last PR #60262

Why?

Pull request #60262 does this for some text, however I missed some. Now they should all be updated across the plugin with this PR.

How?

Manually reviewed codebase for outstanding uncapitalised uses of "Navigation Menu" in user-facing labels

Testing Instructions

Nothing to test as this only changes user-facing labels

@xhemals xhemals requested a review from ajitbohra as a code owner April 6, 2024 02:49
Copy link

github-actions bot commented Apr 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: xhemals <xhemals@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mikachan mikachan added [Type] Copy Issues or PRs that need copy editing assistance [Feature] Navigation Menus Any issue relating to Navigation Menus labels Apr 8, 2024
Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up. One tiny nit otherwise looks good.

wp_navigation: __( 'Editing navigation menu: %s' ),
wp_navigation: __( 'Editing Navigation Menu: %s' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems inconsistent with capitalisation of other entities in this panel. I think we should leave it as it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get your point... For consistency's sake on this panel I will put it back to lowercase here. Maybe something to look at for the future to capitalise the others if they are capitalised elsewhere?

@xhemals xhemals requested a review from getdave April 9, 2024 16:47
Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code quality

@youknowriad youknowriad merged commit 68f0020 into WordPress:trunk Apr 17, 2024
65 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.2 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Navigation Menus Any issue relating to Navigation Menus [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants