New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise capitalisation of Navigation Menu in sidebar #60527
Standardise capitalisation of Navigation Menu in sidebar #60527
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up. One tiny nit otherwise looks good.
wp_navigation: __( 'Editing navigation menu: %s' ), | ||
wp_navigation: __( 'Editing Navigation Menu: %s' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems inconsistent with capitalisation of other entities in this panel. I think we should leave it as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get your point... For consistency's sake on this panel I will put it back to lowercase here. Maybe something to look at for the future to capitalise the others if they are capitalised elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the code quality
What?
Standardising the capitalisation of the phrase "Navigation Menu" in the sidebar. Carrying on from last PR #60262
Why?
Pull request #60262 does this for some text, however I missed some. Now they should all be updated across the plugin with this PR.
How?
Manually reviewed codebase for outstanding uncapitalised uses of "Navigation Menu" in user-facing labels
Testing Instructions
Nothing to test as this only changes user-facing labels