New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not render pattern aria description if not button is rendered #60653
Do not render pattern aria description if not button is rendered #60653
Conversation
* DataViews: Use in patterns page * add export JSON action * add rename action * add delete and reset actions * remove comments
</Async> | ||
) } | ||
</PreviewWrapper> | ||
{ ! isNonUserPattern && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything here is white space change besides this check: ! isNonUserPattern
. I just removed the fragment.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -26 B (0%) Total Size: 1.75 MB
鈩癸笍 View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change makes sense to me 馃憤
I'm going to merge this, but I'd appreciate feedback if there are a11y issues - either with the code or if it's a browser issue. |
What?
@carolinan referring to the patterns list in site editor mentioned here:
I'm not sure if I missed something from the original port of patterns list, but I used the same code from: https://github.com/WordPress/gutenberg/pull/58966/files#diff-8f4940d6721aa050133f42eb236d7078467fc399b0ea236139a750c17e6dde34L143. One difference though is that currently we do not always render a button and this PR fixes that, and doesn't render an aria description div when we do not render a button for the preview.
Besides that, I don't think the
hidden
attribute plays a role here, because it's announced for example in Firefox. I tried removing the attribute though while testing in Crome and it's not announced. Maybe it's a voiceover issue like this one? 馃I've tested with macOs.
So while the announcing is not solved for every OS, we could probably also land this one and handle it separately if we need to.
Testing Instructions