Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Post: Make sure block controls do not show up over sidebar on greater than small viewport #6081

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Apr 9, 2018

Description

This PR tries to fix regression introduced after release 2.6 went out. Editor movers and block settings are displayed over sidebar menu when browsing on greater than small screens (> 600px & < 780px).

Sidenote: Honestly speaking I updated those values randomly to make it work. Let me know what is the proper way to fix it 🙇

How Has This Been Tested?

Manually.

  • Need to set screen width between 600px and 780px.
  • Select one of the blocks.
  • Open advanced block settings.

Screenshots (jpeg or gifs if applicable):

Before

screen shot 2018-04-09 at 13 26 24

After

screen shot 2018-04-09 at 13 49 16

@gziolo gziolo added the [Type] Bug An existing feature does not function as intended label Apr 9, 2018
@gziolo gziolo self-assigned this Apr 9, 2018
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well in my testing but like you I don't have any idea on the logic of these numbers, it's really hard to get right.

@jasmussen
Copy link
Contributor

This also seems good to me! Thanks.

@gziolo gziolo merged commit 410c387 into master Apr 9, 2018
@gziolo gziolo deleted the fix/sidebar-editor-movers branch April 9, 2018 19:46
@gziolo
Copy link
Member Author

gziolo commented Apr 9, 2018

Thanks for confirming my bets :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants