New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Post: Make sure block controls do not show up over sidebar on greater than small viewport #6081

Merged
merged 1 commit into from Apr 9, 2018

Conversation

Projects
None yet
4 participants
@gziolo
Member

gziolo commented Apr 9, 2018

Description

This PR tries to fix regression introduced after release 2.6 went out. Editor movers and block settings are displayed over sidebar menu when browsing on greater than small screens (> 600px & < 780px).

Sidenote: Honestly speaking I updated those values randomly to make it work. Let me know what is the proper way to fix it 馃檱

How Has This Been Tested?

Manually.

  • Need to set screen width between 600px and 780px.
  • Select one of the blocks.
  • Open advanced block settings.

Screenshots (jpeg or gifs if applicable):

Before

screen shot 2018-04-09 at 13 26 24

After

screen shot 2018-04-09 at 13 49 16

@gziolo gziolo added the [Type] Bug label Apr 9, 2018

@gziolo gziolo self-assigned this Apr 9, 2018

@gziolo gziolo requested review from youknowriad, jasmussen and karmatosed Apr 9, 2018

@gziolo gziolo referenced this pull request Apr 9, 2018

Merged

Edit Post: Refactor and expose PluginSidebar as final API #6031

3 of 3 tasks complete
@youknowriad

Seems to work well in my testing but like you I don't have any idea on the logic of these numbers, it's really hard to get right.

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Apr 9, 2018

This also seems good to me! Thanks.

@gziolo gziolo merged commit 410c387 into master Apr 9, 2018

2 checks passed

codecov/project 44.61% remains the same compared to bf29d57
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the fix/sidebar-editor-movers branch Apr 9, 2018

@gziolo

This comment has been minimized.

Member

gziolo commented Apr 9, 2018

Thanks for confirming my bets :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment