Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleGroupControl: Remove deprecated reducedMotion util. #61120

Conversation

DaniGuardiola
Copy link
Contributor

Remove reducedMotion since it is deprecated now. Parent issue: #60902

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@skorasaurus skorasaurus added the [Package] Components /packages/components label Apr 26, 2024
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@DaniGuardiola DaniGuardiola merged commit 694447d into WordPress:trunk Apr 30, 2024
58 of 64 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 30, 2024
@Mamaduka
Copy link
Member

Mamaduka commented Apr 30, 2024

@Mamaduka Mamaduka added the [Type] Code Quality Issues or PRs that relate to code quality label Apr 30, 2024
@tyxla
Copy link
Member

tyxla commented Apr 30, 2024

Yup, just spotted it. Let me fix that.

@Mamaduka
Copy link
Member

This is the second time (in my recent memory) that required checks missed snapshot updates in unit tests. We should probably investigate it.

@tyxla
Copy link
Member

tyxla commented Apr 30, 2024

Fix in #61228

It may be easy to miss because they're not required checks for merging.

cc @DaniGuardiola - let's keep an eye on those and make sure they're all green before merging.

@Mamaduka
Copy link
Member

It may be easy to miss because they're not required checks for merging.

Seems to be an oversight, IMO.

@tyxla
Copy link
Member

tyxla commented Apr 30, 2024

Fixed. Sorry for the breakage 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants