-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToggleGroupControl: Remove deprecated reducedMotion
util.
#61120
ToggleGroupControl: Remove deprecated reducedMotion
util.
#61120
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks 👍
It looks like snapshots don't reflect the changes introduced here and are causing the unit test to fail on the trunk. https://github.com/WordPress/gutenberg/actions/runs/8892080824/job/24415403286 |
Yup, just spotted it. Let me fix that. |
This is the second time (in my recent memory) that required checks missed snapshot updates in unit tests. We should probably investigate it. |
Fix in #61228 It may be easy to miss because they're not required checks for merging. cc @DaniGuardiola - let's keep an eye on those and make sure they're all green before merging. |
Seems to be an oversight, IMO. |
Fixed. Sorry for the breakage 🙌 |
Remove
reducedMotion
since it is deprecated now. Parent issue: #60902