Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Fix snapshot tests of ToggleGroupControl #61228

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Components: Fix snapshot tests of ToggleGroupControl #61228

merged 1 commit into from
Apr 30, 2024

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 30, 2024

What?

Fixing snapshot tests that we broke in #61120

Why?

Just fixing some failing tests.

How?

Ditto

Testing Instructions

All checks should be green

Testing Instructions for Keyboard

None

Screenshots or screencast

@tyxla tyxla added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Apr 30, 2024
@tyxla tyxla requested review from Mamaduka and a team April 30, 2024 09:39
@tyxla tyxla self-assigned this Apr 30, 2024
@tyxla tyxla requested a review from ajitbohra as a code owner April 30, 2024 09:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@tyxla tyxla mentioned this pull request Apr 30, 2024
Merged
@tyxla tyxla enabled auto-merge (squash) April 30, 2024 09:40
@Mamaduka Mamaduka mentioned this pull request Apr 30, 2024
Closed
@DaniGuardiola
Copy link
Contributor

Sorry! 😵‍💫

@tyxla tyxla merged commit 0cb3850 into trunk Apr 30, 2024
67 checks passed
@tyxla tyxla deleted the fix/toggle-group-control-snapshots branch April 30, 2024 10:18
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@tyxla tyxla

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 18.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tyxla @DaniGuardiola @Mamaduka