-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Playwright to v1.44 #61443
base: trunk
Are you sure you want to change the base?
Upgrade Playwright to v1.44 #61443
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
await expect( navBlockNode ).toHaveAccessibleDescription( | ||
/This block is locked./ | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afercia, I think you'll like the new a11y assertions - https://github.com/microsoft/playwright/releases/tag/v1.44.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhu, thanks for pointing me at it 🥳
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
a516c99
to
5910db3
Compare
The RichText e2e tests seem to be failing on Firefox after the upgrade. I couldn't reproduce them manually, but I will continue debugging tomorrow. |
Some of the |
5910db3
to
4cb1608
Compare
@Mamaduka, I'm wondering if we should use |
@WunderBart, do you think there are changes in |
I'm not sure, but considering that |
What?
Upgrade Playwright to v1.44
What's new?
https://github.com/microsoft/playwright/releases/tag/v1.44.0
Testing Instructions