Make color variations fit in a bit better visually #61617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I appreciate the follow-up. Thank you. When you have "scrollbars" always enabled (an option you can enable on OS settings), you'll see that there's a small bug. 
|
|
Size Change: -723 B (-0.04%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Serendipitously I was working on a mockup that explores this exact same treatment, so +1 from me! We could even get away with 24px height in cases where there are many palettes, but 32 seems fine for now. |
|
I appreciate this issue, and it was something I was planning on addressing. Given that Powder has 22 style variations. And this is only half of them being shown:
|
|
Looks solid enough to me. I appreciate the quick iteration. I can replicate the same bug Riad mentioned as well. |
|
I fixed the scrollbars in a5344f1. |
|
Flaky tests detected in 06b7951. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9190137336
|
|
Looks solid to me. The only UX note is that I found it confusing that the color presets were a layer deeper than the typography presets. I could see someone not knowing that they need to click the palette to find the presets: testing.variations.mov |
|
I think there's a small border radius issue (they are cut on the lower corners). It's more visible on the site editor navigation sidebar. 
|
10 tasks
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
* Use smaller placement * remove border radius * fix scrollbars * add the border-radius to the previews --------- Co-authored-by: Ben Dwyer <ben@scruffian.com> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: bgardner <bgardner@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Use smaller placement * remove border radius * fix scrollbars * add the border-radius to the previews --------- Co-authored-by: Ben Dwyer <ben@scruffian.com> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: bgardner <bgardner@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reduces the height to 32px and uses the ui border radius. Closes #61759.
How?
Testing Instructions
Screenshots or screencast