-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Focus Mode: Remove leftover code #61897
Conversation
Size Change: -175 B (-0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Flaky tests detected in f07d4f6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9211040083
|
1433a45
to
697fc64
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the "navigation editor" and with all this code removed the experience is 100% the same as it is on trunk
:
- no appender in both edit and view outside the nav block
- not sure what the padding was doing b/c there is no padding on trunk either.
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: draganescu <andraganescu@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: draganescu <andraganescu@git.wordpress.org>
What?
When trying to align post and site editors, I noticed that the Navigation block focus mode has a lot of specific custom code to make it work as it should. But after digging a little bit more, I found that most of that code is actually useless and already handled elsewhere. This PR just cleans these things a little bit:
This code was first introduced in the initial PR that introduced Navigation focus mode #39286
Testing Instructions
1- Open the site editor
2- Click navigation
3- Click the "edit" link in the dropdown in the sidebar
4- You should be able to edit the navigation menu properly, a padding is visible around the canvas and there's no root level appender.