Update: Implement new parent and order design. #61918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +935 B (+0.05%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
update/implement-new-parent-and-page-design
branch
2 times, most recently
from
e7b4ae8
to
d08b9d8
Compare
ntsekouras
reviewed
May 27, 2024
ntsekouras
reviewed
May 27, 2024
| @@ -173,6 +173,7 @@ export function PageAttributesParent() { | |||
| options={ parentOptions } | |||
| onFilterValueChange={ debounce( handleKeydown, 300 ) } | |||
| onChange={ handleChange } | |||
| hideLabelFromVision | |||
There was a problem hiding this comment.
The new designs shared here include some helping text as well. Is this still the case @jameskoster ?
There was a problem hiding this comment.
Yeah I think we should include the help text:
ntsekouras
reviewed
May 27, 2024
ntsekouras
reviewed
May 27, 2024
|
Re-ordering feels a little prominent given it's a seldom-used feature. It's an improvement on trunk but do you think it would be feasible to move it into a modal, accessed from the ellipsis menu? 
|
|
Hi @jameskoster,
This would involve implementing a reorder page action. A little bit like the rename. Are we ok with it being an action e.g.: something that could be done from the dataviews page list? I think it seems fine but I want to confirm. |
|
I think that's okay, but I'd appreciate a gut-check from @jasmussen. |
|
The change seems okay, especially for Friday, but we should probably improve it further, it's not clear at all what Order does, and "parent" is ambiguous. |
|
@jasmussen sorry I should have been more specific. It's a question about where to place access to re-ordering. See the mockup here as an alternative to having it appear as a row in the summary panel. |
|
Ah, thanks for clarifying. Yeah it's tricky, it reduces the prominence, but that may be fine? In a block editor context, you'd most likely reorder your menus through a custom menu rather than changing the page order. But it is definitely harder to find. If we go with this and get confusion in the beta period, are we okay with a full revert back to a panel, pending better ideas for 6.7? |
|
Yeah that seems reasonable. @jorgefilipecosta do you think there's time to try the modal approach in this PR before the beta deadline? Or should we merge this and follow up with the modal separately? |
jorgefilipecosta
force-pushed
the
update/implement-new-parent-and-page-design
branch
from
d08b9d8
to
b8a0b62
Compare
Hi @jameskoster, I think ideally we should merge this component as the action approach for order may need more discussion (it needs some checks in addition to the other actions). |
|
@jorgefilipecosta okay, that sounds good to me. I pushed a couple of small tweaks. |
jameskoster
approved these changes
May 30, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new parent and order design.
Related #60291, #59689.
Screenshot
Testing Instructions
Verified I could still change the parent and order of a page.