-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace react-redux with the data module in the editor module #6202
Conversation
@@ -44,7 +44,6 @@ | |||
"react-color": "2.13.4", | |||
"react-datepicker": "0.61.0", | |||
"react-dom": "16.3.0", | |||
"react-redux": "5.0.6", | |||
"redux": "3.7.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Travis complains 😱 😄 |
Stupid snapshots :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I tested and didn't discover any regression. Awesome work 🥇
We still use redux-multi
and redux-optimist
. Should we reavelaute their usage?
// RichText provider: | ||
// | ||
// - context.onUndo | ||
// - context.onRedo | ||
// - context.onCreateUndoLevel | ||
[ | ||
RichTextProvider, | ||
bindActionCreators( { | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we have this sorted out, too. Awesome 💯
|
This PR updates all occurrences of react-redux in the
editor
module withwithSelect
andwithDispatch
from the data module. I notice a gain of100Kb
unminified in the editor module. It's not huge but still a good improvement.Testing instructions
Check that: