Update sidebar title + icon + site title alignment #62191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +6 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
richtabor
added
[Type] Bug
richtabor
approved these changes
May 31, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Jun 1, 2024
There was a problem hiding this comment.
Changing alignment to center is fine in most cases, but I understand that flex-start is used intentionally when the text is long.
For example, if you have a long navigation menu, it will be displayed as follows.
How about adjusting the top padding while maintaining flex-start? padding: $grid-unit-05 * 0.5 0 0 0 seems well balanced to me.
|
Oh yes, good point. Using padding is never going to be 100% perfect, but it's an improvement on trunk. I think ideally we update these buttons to be 32px rather than the non-standard 36px, then set the line-height on the title to 32px as well. That would align everything nicely, but it's a bigger change—one to explore separately. |
t-hamano
approved these changes
Jun 3, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
* Update sidebar title + icon alignement * Fix alignment between sidebar title and site title * revert alignment, adjust padding Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
ellatrix
added
the
Backport to WP 6.6 Beta/RC
|
Don't forget the |
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Update sidebar title + icon alignement * Fix alignment between sidebar title and site title * revert alignment, adjust padding Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Update sidebar title + icon alignement * Fix alignment between sidebar title and site title * revert alignment, adjust padding Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Update sidebar title + icon alignement * Fix alignment between sidebar title and site title * revert alignment, adjust padding Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
ellatrix
removed
the
Backport to WP 6.6 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure when this visual regression occurred, but the sidebar title has slipped out of alignment with the icons it often appears next to, and with the site title. It appears to be resting on a different plain to the icons, which is creating some tension between the
<button and the title.This PR addresses these details, illustrated below:
Testing Instructions