-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sidebar title + icon + site title alignment #62191
Conversation
Size Change: +6 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing alignment
to center
is fine in most cases, but I understand that flex-start
is used intentionally when the text is long.
For example, if you have a long navigation menu, it will be displayed as follows.
How about adjusting the top padding while maintaining flex-start
? padding: $grid-unit-05 * 0.5 0 0 0
seems well balanced to me.
Oh yes, good point. Using padding is never going to be 100% perfect, but it's an improvement on trunk. I think ideally we update these buttons to be 32px rather than the non-standard 36px, then set the line-height on the title to 32px as well. That would align everything nicely, but it's a bigger change—one to explore separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Update sidebar title + icon alignement * Fix alignment between sidebar title and site title * revert alignment, adjust padding Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Don't forget the |
* Update sidebar title + icon alignement * Fix alignment between sidebar title and site title * revert alignment, adjust padding Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
* Update sidebar title + icon alignement * Fix alignment between sidebar title and site title * revert alignment, adjust padding Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
* Update sidebar title + icon alignement * Fix alignment between sidebar title and site title * revert alignment, adjust padding Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This was cherry-picked to the wp/6.6 branch. |
I'm unsure when this visual regression occurred, but the sidebar title has slipped out of alignment with the icons it often appears next to, and with the site title. It appears to be resting on a different plain to the icons, which is creating some tension between the
<
button and the title.This PR addresses these details, illustrated below:
Testing Instructions